Looking at AbstractHttpRequestWithBodyBuilder, I can see other places where interpolation is called, but not when setting a body.
Is there some way I can get the data in there?
Cheers,
Luke.
P.S. What do you guys do for tests ? I’m loathe to submit pull requests when there aren’t any tests in the build. Do you run a separate test suite somewhere?
Regarding the tests, ahem, hum, well…
We have integration tests with the Cloud Foundry app and a rails app, but nothing very clean and stable and we haven’t published them.
And honestly, I didn’t anticipate that people would build the master and play with it so soon…
We do want to have automated tests, but we still have to puzzle how.
What we’re considering is :
Akka TestKit
Have a look at how tests are done in AsyncHttpClient
Have a maven plugin for embedding and launching Gatling (we plan on doing this anyway) and run an embedded server.
We definitively want to have this before releasing the 1.1.
Like always, the problem is time
Do you have any idea on the topic?
Anyway, thanks for testing and reporting, that’s a big help!
I’ve also sent a pull request as there was an issue with overmatching of the interpolated value within a JSON string.
I think it makes sense to at least have some unit tests (for things like this, for example), to give some confidence that things are still working as you expect. Obviously you quite easily put together integration tests with gatling :-), but they’d need a test app to run against which would could cater for the different test cases you want to cover. If your other app can be run standalone and had a gatling test suite, I guess you can just ask users to run the tests for that before making changes.
I completely agree.
We’ll have some Spec2 tests for Helpers and other kinds of standalone components and publish a clean webapp.
We’ll work on this next week.