JDBC Simulations extension and request for feedback

Gatling (Open-Source)
1

Hi, I wrote a JDBC extension and I’m hoping for code reviews or any feedback. My Scala is rusty and I usually use sbt instead of maven.

https://github.com/tmcgrath/gatling-sql

I’m interested in any ideas for improvement, but a few things stand out-

  • The SqlAction class in the sql package seems a bit awkward with the nested callbacks?

  • Code isn’t closing any of the pool connections on either success or failures.

  • Setting the JDBC driver in the ThriftServerSimulation might be better in the ConnectionPool itself and use a config var for it.

Thoughts?

Thanks in advance,
Todd